fix(google): send thinkingLevel for any model with an effort ladder - #978
Open
DevMello wants to merge 1 commit into
Open
fix(google): send thinkingLevel for any model with an effort ladder#978DevMello wants to merge 1 commit into
DevMello wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Google adapter now uses configured reasoning-effort ladders for eligible Gemini and Vertex models. Tests cover effort mapping, clamping, Vertex configuration, Flash fallback, and image-model exclusions. ChangesGoogle reasoning request handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gemini-3.1-pro-previewnow actually sendsgenerationConfig.thinkingConfig.thinkingLevelon the wire. The catalog has advertised low/medium/high for this model since the 3.6 rollout, but the adapter hardcoded thinking togemini-3.5-flashandgemini-3.6-flash, so the picker choice was silently ignored.google-vertexentry ships none, so the Vertex freeze documented in the 260722 rollout plan is preserved. Image models are excluded becausethinkingConfigwould suppressresponseModalities.Verification
bun test tests/google-hardening.test.ts tests/google-adapter.test.ts tests/google-antigravity-wire.test.ts tests/google-vertex-stream.test.ts(77 pass)bun run typecheck,bun run lint:gui,bun run privacy:scanbun test --isolate ./tests/full suite green (7999 pass, 0 fail)minimaltolow, Vertex emits only with an explicit ladder, unladdered direct flash keeps its slice, image models keepresponseModalitiesunder a provider-wide ladder.Checklist
Summary by CodeRabbit