Introduce new addressing- and telegram-classes - #48
Open
SystemKeeper wants to merge 7 commits into
Open
SystemKeeper wants to merge 7 commits into
SystemKeeper wants to merge 7 commits into
Conversation
…reeLevel, TwoLevel and FreeStyle). This also supports extended GAs as supported starting with ETS4 and using the full 16-bit GA range.
Addressing: - Moved Addressing to separate classes (not relying on string for GAs) - Support for extended GAs (i.e. full 16 bit group addresses) - Support for different GA styles (ThreeLevel, TwoLevel, Free) Telegram processing: - Added classes for ControlField1 and ControlField2 - Added enums to better understand what the ControlFields actually represent - Changed event parameters to standard .net pattern - Fixed bugs for CF1 / CF2 (wrong hop count, wrong broadcast bit, 0.0.0 not allowed as address) Testes: - Added tests for Addressing-classes - Added tests for ControlField-classes Readme: - Updated to reflect changes of this commit
GA was tested against SourceAddress instead of DestinationAddress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original intend of this branch was to allow extended GAs, i.e. full 16 bit group addresses. Went a bit further than I originally anticipated, so this is quite a large PR and introduces some API changes. Let me know what you think.
Here are the changes:
Addressing:
Telegram processing:
Testes:
Readme: