[P0][Correctness] unique marker が複数contigへ分散した場合に少数側を黙って捨てない - #55
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8050cbc19c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _marker_split_message(split: dict) -> str: | ||
| names = ", ".join(f"{x['marker']}->{x['contig']}" for x in split["minority"][:5]) | ||
| return f"Unique marker hits are split across target contigs: {split['major_count']}/{split['total']} on {split['major_contig']}; minority: {names}." |
There was a problem hiding this comment.
When the Japanese locale is active, both this dynamic split warning and the new fixed warning from score_confidence fall through localizeMessage and are displayed verbatim in English because this change adds neither translation patterns nor locale strings. Add Japanese handling for both messages so users can understand why confidence was reduced.
AGENTS.md reference: AGENTS.md:L110-L110
Useful? React with 👍 / 👎.
# Conflicts: # backend/qtlift/analysis.py # backend/qtlift/pipeline.py
8050cbc to
112898f
Compare
Fixes #50
実施内容
テスト
uff check\ パス