Skip to content

fix issue where if field had val list:List<String>? = null would cause an error to be thrown in the browser console #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kf7mxe wants to merge 2 commits into
base: version-8
Choose a base branch
from
Open

fix issue where if field had val list:List<String>? = null would cause an error to be thrown in the browser console #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0859d9
fix issue where if field had val list:List<String>? = null would caus…
kf7mxe Apr 17, 2026
de0fcee
Merge branch 'version-8' into tb/fixNullListThrowError
UnknownJoe796 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/src/commonMain/kotlin/com/lightningkite/kiteui/forms/HorizontalListRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ object HorizontalListRenderer : Renderer<List<Any?>> {
override val name: String = "Horizontal List" // by Claude

override fun priority(context: RenderContext<List<Any?>>, module: FormModule): Float {
if (context.serializer.descriptor.isNullable) return -1f
if (context.serializer.descriptor.kind != StructureKind.LIST) return -1f

// Higher priority for explicit annotation - by Claude
Expand Down
1 change: 1 addition & 0 deletions client/src/commonMain/kotlin/com/lightningkite/kiteui/forms/ListRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ object ListRenderer : Renderer<List<Any?>> {
override val name: String = "List" // by Claude

override fun priority(context: RenderContext<List<Any?>>, module: FormModule): Float {
if (context.serializer.descriptor.isNullable) return -1f
return if (context.serializer.descriptor.kind == StructureKind.LIST) 0.8f else -1f
}

Expand Down
1 change: 1 addition & 0 deletions client/src/commonMain/kotlin/com/lightningkite/kiteui/forms/SetRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ object SetRenderer : Renderer<Set<Any?>> {

override fun priority(context: RenderContext<Set<Any?>>, module: FormModule): Float {
val descriptor = context.serializer.descriptor
if (descriptor.isNullable) return -1f
// Match sets specifically - they have StructureKind.LIST but serialName contains "Set"
return if (descriptor.kind == StructureKind.LIST && descriptor.serialName.contains("Set")) 0.85f else -1f
}
Expand Down
1 change: 1 addition & 0 deletions client/src/commonMain/kotlin/com/lightningkite/kiteui/forms/TableRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ object TableRenderer : Renderer<List<Any?>> {
override val name: String = "Table" // by Claude

override fun priority(context: RenderContext<List<Any?>>, module: FormModule): Float {
if (context.serializer.descriptor.isNullable) return -1f
// Only match lists where inner type has serializableProperties
if (context.serializer.descriptor.kind != StructureKind.LIST) return -1f

Expand Down
Loading