Skip to content

change expiresAt to be nullable and do default check with at for backward compatibility with mobile apps #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kf7mxe wants to merge 5 commits into
base: version-5
Choose a base branch
from
Open

change expiresAt to be nullable and do default check with at for backward compatibility with mobile apps #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
170f891
made expiresAt nullable and do default check with at for backward com…
kf7mxe Mar 9, 2026
5d4d440
add default parameter null to expiresAt
kf7mxe Mar 9, 2026
c2e4045
fix signing info to handle the null expires at
kf7mxe Mar 9, 2026
0f78871
Merge branch 'version-5' into tb/backwardCompatProofExpiresAt
kf7mxe Apr 22, 2026
57521e2
Merge branch 'version-5' into tb/backwardCompatProofExpiresAt
kf7mxe Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...src/main/kotlin/com/lightningkite/lightningserver/sessions/proofs/extensions/Proof.ext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.lightningkite.lightningserver.sessions.proofs.extensions

import com.lightningkite.lightningserver.runtime.ServerRuntime
import com.lightningkite.lightningserver.runtime.now
import com.lightningkite.lightningserver.sessions.proofs.Proof
import com.lightningkite.lightningserver.sessions.proofs.proofMethods
import kotlin.time.Duration.Companion.hours

context(_: ServerRuntime)
public val Proof.expired: Boolean get() = (expiresAt ?: (at + 1.hours)) < now()

context(server: ServerRuntime)
public suspend fun Proof.isValid(): Boolean =
server.proofMethods.find { it.info.via == via }?.verify(this) == true
6 changes: 2 additions & 4 deletions ...rc/main/kotlin/com/lightningkite/lightningserver/sessions/proofs/extensions/Signer.ext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import com.lightningkite.lightningserver.sessions.proofs.*
import kotlinx.io.*
import kotlin.io.encoding.Base64
import kotlin.time.Duration
import kotlin.time.Duration.Companion.hours
import kotlin.time.Instant

private fun signingInfo(
Expand All @@ -23,10 +24,7 @@ private fun signingInfo(
writeString(value)
writeInt(strength)
writeLong(at.toEpochMilliseconds())
writeLong(
expiresAt?.toEpochMilliseconds()
?: throw IllegalStateException("expiredAt cannot be null for proof signature verification")
)
writeLong(expiresAt?.toEpochMilliseconds() ?: (at.plus(1.hours)).toEpochMilliseconds())
}
.readByteArray()

Expand Down
Loading