Condition to Bson fix#14
Open
WesleyEdwards wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ListAllElements was having issues with a list of an object.
Added a test to account for this case and changes to
ListAllElementsandNotBson convertersFor mongo filters,
$noris a "Top-level logical query operator", meaning that it cannot be nested directly under a field or an$elemMatch.Previously,
Condition.Notalways used$nor.This is invalid, because
$elemMatchexpects a field condition instead of a top-level query operator.But this is valid:
But
$noris still necessary when wrapping field conditions and other logical operators (like 'and' and 'or')i.e.
{ "$nor": [ { "subField": 1 } ] })So I changed the 'Not' Condition -> Bson to account for that. I also made it so
ListAllElementsuses theNotconversion logic because it would run into the same problem