document ALPN loadbalancer issues; use manager TLSConfig for autocert#221
Merged
Roasbeef merged 2 commits intolightninglabs:masterfrom Mar 24, 2026
Merged
document ALPN loadbalancer issues; use manager TLSConfig for autocert#221Roasbeef merged 2 commits intolightninglabs:masterfrom
Roasbeef merged 2 commits intolightninglabs:masterfrom
Conversation
Use autocert.Manager.TLSConfig() instead of assembling GetCertificate TLS configs manually. This keeps autocert's ALPN and ACME defaults while preserving Aperture's cipher suite and minimum TLS version settings.
Document loadbalancer ALPN requirements for gRPC deployments. TLS-terminating load balancers must advertise h2 over ALPN, or clients can fail with "missing selected ALPN property". Call out AWS NLB default ALPN policy and recommended options. Note that TCP passthrough keeps ALPN negotiation at aperture.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document loadbalancer ALPN requirements for gRPC deployments. TLS-terminating load balancers must advertise h2 over ALPN, or clients can fail with "missing selected ALPN property". Call out AWS NLB default ALPN policy and recommended options. Note that TCP passthrough keeps ALPN negotiation at aperture.
Use autocert.Manager.TLSConfig() instead of assembling GetCertificate TLS configs manually. This keeps autocert's ALPN and ACME defaultswhile preserving Aperture's cipher suite and minimum TLS version
settings.
Replaces #213