Clarify installation and update guidance - #32
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe update workflow now prints a branch-specific GitHub archive installation command for pip-installed setups. Tests verify the exact guidance, while the README documents virtual environment installation and checkout versus archive update behavior. ChangesUpdate guidance
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 67-70: Update the Windows virtual-environment activation
instructions in the setup section to document both Command Prompt’s
.venv\Scripts\activate and PowerShell’s .venv\Scripts\Activate.ps1 forms, while
preserving the surrounding editable-install guidance.
In `@tests/test_update.py`:
- Around line 48-49: Update the test containing the PIP_UPDATE_COMMAND
assertions to independently assert the expected GitHub archive command literal
rather than relying on the imported implementation constant. Retain the existing
negative assertion that excludes the legacy “pip install -U panoptic” command.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: fe2f3a07-9cdb-4ad7-b667-f75b8635184d
📒 Files selected for processing (3)
README.mdpanoptic/update.pytests/test_update.py
Summary
panopticname on PyPI belongs to an unrelated projecttomlidependencyVerification
Summary by CodeRabbit
Documentation
main.zip).Bug Fixes
python -m pip install --upgrade ...main.zipcommand, and the legacy message is no longer shown.Tests