Fix race condition with creating lightstep-reporting-thread#152
Open
spkrka wants to merge 1 commit intolightstep:masterfrom
Open
Fix race condition with creating lightstep-reporting-thread#152spkrka wants to merge 1 commit intolightstep:masterfrom
spkrka wants to merge 1 commit intolightstep:masterfrom
Conversation
Due to lack of synchronization it's possible to spawn multiple threads and forget the reference to everyone except one. This means that the forgotten threads will never be interrupted and keep running forever
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to lack of synchronization it's possible to spawn multiple
threads and forget the reference to everyone except one.
This means that the forgotten threads will never be interrupted and
keep running forever