Surface contact form submission errors instead of swallowing them - #6
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Surface contact form submission errors instead of swallowing them#6devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The only JS in the repo is the contact form handler in
index.html. Both failure paths (non-2xx Formspree response and a thrownfetch) ended in a bareerrorMsg.hidden = falsewith the caught error discarded, so a validation rejection, a rate limit, and an offline browser were indistinguishable — for the visitor and in the console.Now the error is propagated to both audiences:
{ errors: [{ message }] }/{ error }payload, falling back toHTTP <status> <statusText>; JSON parse failure is itself logged rather than ignored… (detail)) and every failure isconsole.error-ed#contactForm/#formSuccess/#formErrornow throw instead of failing with aTypeErroronaddEventListener, and the submit button is disabled for the duration of the request (re-enabled infinally) so a failed submit can't be double-fired.Link to Devin session: https://app.devin.ai/sessions/74774155788442d78377a73aa25bec90
Requested by: @liikane