Dedupe repeated CSS declarations and form-message JS in index.html - #8
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Dedupe repeated CSS declarations and form-message JS in index.html#8devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.htmlis the only source file in the repo; its<style>block repeated the same declaration groups across unrelated selectors, and the submit handler toggled the two status paragraphs by hand. Consolidated the repeats into grouped rules plus tokens, and the JS toggling into one helper.Shared rules added (each selector keeps its own radius/padding/colors):
New tokens replace repeated literals:
--surface(rgba(255,255,255,0.05)),--radius-lg(28px),--radius-pill(999px),--ease(0.2s ease, used by both the.btnand.field input/textareatransitions).JS:
successMsg/errorMsgwere each toggled in three places; nowwith the non-ok response funnelled into the existing
catchviathrow, so there is a single error path.Verified with headless-Chrome screenshots before/after: the only pixel difference is the contact card's hairline border, whose alpha is normalized from
0.12to the shared--border(0.1) — intentional, and visually indistinguishable.Not touched:
zipper-unzipper.zipcontains a vendored third-partyzipper-unzipper.phpwith its own duplication (the$GLOBALS['status'] = array(...)assignment appears 10x, and the readable/writable guard pairs are near-identical between the zip and rar extractors). Refactoring it would mean rewriting a GPL upstream file that only exists as a binary zip in the repo, so I left it alone — happy to unpack it into a real source file and clean it up if you want.Link to Devin session: https://app.devin.ai/sessions/23935b53eab346a1ad66bbb9e806a836
Requested by: @liikane