feat(studio): Deploy configuration and tests - #36
Conversation
- Add WASM build configuration (Trunk.toml, build.sh) - Add index.html for standalone and dashboard-embedded studio - Integrate studio with dashboard backend APIs - Add 15 unit tests for types and chart components
There was a problem hiding this comment.
💡 Codex Review
rust-ai-agents/crates/studio/src/api/types.rs
Lines 49 to 52 in f765707
TraceEntryType on the client is serialized/deserialized with #[serde(rename_all = "snake_case")], while the server’s TraceEntryType (crates/dashboard/src/state.rs) emits variant names in their original casing (e.g., LlmRequest). Any trace update delivered over the API/WebSocket will therefore fail to deserialize in the UI because it receives "LlmRequest" but expects "llm_request", so trace rendering will break whenever traces are emitted.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Serve static files for studio WASM | ||
| .nest_service("/studio/pkg", ServeDir::new("static/studio/pkg")) | ||
| .layer(cors) |
There was a problem hiding this comment.
Studio assets routed to non-existent directory
The new /studio route nests a static service at ServeDir::new("static/studio/pkg"), but the repository contains only crates/dashboard/static/studio/index.html with no static/studio/pkg folder (and the build output lives under crates/dashboard/static/studio/pkg if built). When running the dashboard from the workspace root, every /studio/pkg/*.js request will 404 and the WASM module referenced by static/studio/index.html cannot load, so the Studio page fails at runtime unless the working directory and asset layout are manually adjusted.
Useful? React with 👍 / 👎.
Changes