Skip to content
This repository was archived by the owner on Mar 21, 2026. It is now read-only.

feat(studio): Deploy configuration and tests - #36

Merged
limaronaldo merged 5 commits into
mainfrom
feat/studio-deploy-tests
Dec 7, 2025
Merged

feat(studio): Deploy configuration and tests#36
limaronaldo merged 5 commits into
mainfrom
feat/studio-deploy-tests

Conversation

@limaronaldo

Copy link
Copy Markdown
Owner

Changes

  • WASM build setup with Trunk
  • Dashboard integration at /studio route
  • 15 unit tests for types.rs and charts.rs

- Add WASM build configuration (Trunk.toml, build.sh)
- Add index.html for standalone and dashboard-embedded studio
- Integrate studio with dashboard backend APIs
- Add 15 unit tests for types and chart components

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

/// Type of trace entry
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
#[serde(rename_all = "snake_case")]
pub enum TraceEntryType {

P1 Badge Align trace entry casing with backend payloads

TraceEntryType on the client is serialized/deserialized with #[serde(rename_all = "snake_case")], while the server’s TraceEntryType (crates/dashboard/src/state.rs) emits variant names in their original casing (e.g., LlmRequest). Any trace update delivered over the API/WebSocket will therefore fail to deserialize in the UI because it receives "LlmRequest" but expects "llm_request", so trace rendering will break whenever traces are emitted.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +72 to 74
// Serve static files for studio WASM
.nest_service("/studio/pkg", ServeDir::new("static/studio/pkg"))
.layer(cors)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Studio assets routed to non-existent directory

The new /studio route nests a static service at ServeDir::new("static/studio/pkg"), but the repository contains only crates/dashboard/static/studio/index.html with no static/studio/pkg folder (and the build output lives under crates/dashboard/static/studio/pkg if built). When running the dashboard from the workspace root, every /studio/pkg/*.js request will 404 and the WASM module referenced by static/studio/index.html cannot load, so the Studio page fails at runtime unless the working directory and asset layout are manually adjusted.

Useful? React with 👍 / 👎.

@limaronaldo
limaronaldo merged commit 6de9159 into main Dec 7, 2025
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant