Repository navigation
LIM-2424: declare agreement.launch in align_get_accepted_plan's output schema - #15
Merged
Merged
Conversation
allsmog
approved these changes
Oct 23, 2026
allsmog
left a comment
Contributor
There was a problem hiding this comment.
Approved @ b4a4747. Read the diff. agreement.launch is now declared in the MCP output schema, which has additionalProperties: false, so a validating client no longer rejects the whole result. The new test-mcp:custom step covers that. I'm signing off on the Northstar API snapshot change it brings. It's only the tools/list schema gaining the launch enum in four step files, with no behavior change. Gate: I'll run it on main after the merges.
…t schema P1-3 (820aa15) added agreement.launch ("approved" | "pending" | "not_applicable") to the accepted plan's structuredContent but left it out of the output schema to keep the Northstar tool listing unchanged. The published schema has additionalProperties: false, so a validating MCP client (the SDK client included) rejected align_get_accepted_plan on every custom scenario: "data/agreement must NOT have additional properties". Found by Mini S0 on main 696c6b3. The gate missed it because test-mcp only ran on Northstar. - lib/mcp/register.ts: declare launch as a required enum; the comment no longer claims the schema isn't strict. - scripts/test-mcp-custom.mjs + test-all step test-mcp:custom: the same validating client on a custom scenario, then back to Northstar. Fails on 696c6b3 with the error above; passes here. - Northstar snapshot: 4 step files re-captured (01, 04, 25, 28). The only change is the tool listing's agreement schema (launch added to properties and required). No Northstar state, API or test-flow output changed. Needs Sean's sign-off as a listing change.
allsmog
force-pushed
the
agent/LIM-2424-mcp-launch-schema
branch
from
October 23, 2026 16:24
b4a4747 to
8c9ec16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug on main (
696c6b3) found by Mini S0. On every custom scenario, a validating MCP client rejectsalign_get_accepted_plan:Cause. P1-3 (
820aa15) addedagreement.launch(approved|pending|not_applicable) to the tool's structuredContent. It was left out of the output schema to keep the Northstar tool listing unchanged, on the wrong belief that the schema wasn't strict. The published schema hasadditionalProperties: false. The gate missed it becausetest-mcponly ran on Northstar.Impact. Local Mode L agents on custom scenarios. Hosted mode has no MCP (404), so hosted testers aren't affected.
Changes
lib/mcp/register.ts: declareslaunchas a required enum inAcceptedPlanOut.agreement, and fixes the comment.scripts/test-mcp-custom.mjs, plus the test-all steptest-mcp:custom: the same validating SDK client, run on a custom scenario, then reset to Northstar.01,04,25,28). A JSON-path diff shows the only change is the tool listing'soutputSchema.agreement:properties.launchis added and"launch"joinsrequired. No Northstar state, API response or test-flow output changed. @allsmog: this is a tool-listing change and needs your sign-off.Gate:
scripts/test-all.sh 3264passes all 16 steps, including the newtest-mcp:custom. The rest:Independent of #10, #11, #13 and #14.
https://claude.ai/code/session_01NdA1ZeBBUXwxCGPZcJhfJM