Conversation
guimard
force-pushed
the
rdp
branch
2 times, most recently
from
January 13, 2026 11:29
ba12740 to
cff2f76
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive RDP (Remote Desktop Protocol) support to the LLNG-PAM-MODULE project by integrating WALLIX Redemption as an RDP proxy with LemonLDAP::NG authentication. The implementation provides session recording, unified SSH/RDP authorization, and native RDP client support.
Changes:
- Adds WALLIX Redemption RDP proxy with Python-based authentication hook integrated with LemonLDAP::NG
- Creates Docker-based proof-of-concept environment with SSO and RDP proxy services
- Provides comprehensive documentation including feasibility study, setup guides, and competitor analysis
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 24 comments.
Show a summary per file
| File | Description |
|---|---|
| docker-rdp-poc/README.md | Main documentation for RDP PoC setup and usage |
| docker-rdp-poc/windows-target/README.md | Windows Server configuration guide for RDP targets |
| docker-rdp-poc/docker-compose.yml | Docker Compose orchestration for SSO and RDP proxy services |
| docker-rdp-poc/lmConf-1.json | LemonLDAP::NG portal configuration with PAM Access settings |
| docker-rdp-poc/sso/Dockerfile | Minimal Dockerfile extending LLNG portal image |
| docker-rdp-poc/redemption/Dockerfile | Multi-stage build for WALLIX Redemption from source |
| docker-rdp-poc/redemption/config/rdpproxy.ini | Redemption proxy configuration with LLNG integration |
| docker-rdp-poc/redemption/config/passthrough.py | Python authentication hook calling LLNG API |
| doc/rdp-feasibility.md | Technical feasibility study evaluating RDP solutions |
| doc/competitors.md | Competitor analysis including RDP capabilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guimard
force-pushed
the
rdp
branch
2 times, most recently
from
January 21, 2026 21:25
60a5bf5 to
b14399e
Compare
- Add libboost-build-dev to Dockerfile for bjam build tool - Add try/except for requests import with graceful error handling - Add robust logging configuration with fallback to stderr
Security fixes: - Remove password logging from passthrough.py (was in debug logs) - Add ensure_ascii=True to JSON output Functional fixes: - Add chmod for passthrough.py script - Remove invalid health check endpoint - Fix LLNG_SERVER_TOKEN in docker-compose.yml - Remove unused imports (datetime, Optional) - Update README enrollment instructions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix "15-21 months" → "15-21 days" in rdp-feasibility.md - Add ensure_ascii=True to error case in passthrough.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix $hGroup -> $hGroups variable name in rdp-feasibility.md - Generate self-signed certificates for PoC in Dockerfile 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
guimard
added a commit
that referenced
this pull request
Sep 6, 2026
The plugin-boundary study was written against the published plugin code. The upstream repository has moved since: of the nine tickets the R-P sheets cite, six are now fixed on linagora/lemonldap-ng-plugins main (#58, #59, #60, #69, #72, #74) and three are in review (#50 -> PR #92; #54/#66/#68 -> PRs #87 and #88; #63 -> PR #90). Leaving "no fix exists" in the sheets would have made the study wrong within a week of being written. None of it is released, so no residual score moves and no matrix cell changes: the matrices describe what an operator can deploy today, and that is the property the checker enforces. What changes is what the acceptance of R-P3 and R-P7 actually commits to. "A fix that does not exist" and "a fix that is merged but unpublished" are different decisions, and the homologation authority should be signing the second one. Two upstream changes are recorded because they invalidate text rather than scores: - #56 makes the source-address pin fail closed. R-P1 listed the pin as a mitigating factor without saying that it was silently omitted whenever the observed address was unusable -- which is the case the operator never sees. - #55 caps a voucher that no fingerprint binds at 900 s instead of 12 h. That narrows the window R-P1 describes for a self-declared bastion, but only for a caller that presents no fingerprint. R-P6's mitigating factor "ob-bastion-id shows a missing device-id" stops holding the day the portal is upgraded: #86 removes /pam/bastion-token, which is the endpoint ob-bastion-id calls. MT51 and open-bastion#246 carry the migration to POST /pam/whoami (upstream PR #94). The upgrade note is stated in the sheets rather than left for the upgrade night: it removes an endpoint open-bastion still calls, shortens unbound vouchers by a factor of 48, and makes the ssh-ca admin routes deny until sshCaAdminRule is set. Verified: tests/test_ob_ebios_matrices.sh passes (47 sheets, no divergence), prettier is clean on the three files touched, and the link/anchor sweep reports only the pre-existing forward reference to the llng-configuration.md section that PR #238 adds. Refs #218, #246 Claude-Session: https://claude.ai/code/session_011q88Fs4nFuUs7JMvmgbBTN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.