Allow Strassen-Winograd' matrix mult. to work over generic fields#380
Open
ClementPernet wants to merge 9 commits intomasterfrom
Open
Allow Strassen-Winograd' matrix mult. to work over generic fields#380ClementPernet wants to merge 9 commits intomasterfrom
ClementPernet wants to merge 9 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the architecture of fgemm is written with genericity in mind (wrt the base field), the management of delayed bounds in Strassen-Winograd's algorithm was somehow hardcoded there, which made this code unusable for any base field that does not complied with the Delayed or Lazy categories (delaying modular reductions).
This PR fixes this issue by
With this branch applied, no performance regression were noted and test-fgemm now support ModularExtended which is not a DelayedTag category.