fix(android): conditionally apply kotlin-android for AGP 9 built-in Kotlin support#142
Merged
onevcat merged 1 commit intoApr 3, 2026
Conversation
Member
|
Thanks for the PR! The approach looks correct to me — conditionally applying I'm not super confident with the Android build system though, so @YkSix could you take a look? It would be great if you could also verify this with an AGP 9 environment to make sure everything builds cleanly. |
Member
|
Since our Android expert is currently on vacation, I verified locally that this change doesn't break existing builds on AGP < 9. Flutter itself doesn't support AGP 9 for plugins yet (see flutter/flutter#181383), so we can't fully verify the AGP 9 path at this time. Merging for now — we'll revisit and do a full verification once Flutter officially supports AGP 9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGP 9+ has built-in Kotlin support, and explicitly applying
kotlin-androidconflicts with it.This change conditionally applies
kotlin-androidandkotlinOptionsonly when AGP < 9.References