fix: prevent crash when device Keystore fails during token persistence#190
Merged
Merged
Conversation
fukuchancat
force-pushed
the
fix/keystore-init-crash-186
branch
from
833bacc to
d1919bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186.
Minimal hotfix to stop the crash from a broken device Keystore
(
ProviderException: Keystore key generation failed). Two unguardedStringAesCipherinit paths are wrapped:EncryptorHolderpre-init (background, latency optimization only) catches and logs.LineAuthenticationControllerreturnsINTERNAL_ERRORinstead of crashing onsaveAccessTokenfailure.Scope is limited to preventing the crash; on affected devices login fails gracefully rather than succeeding.
Test:
testKeystoreErrorOfSavingAccessTokeninjects a throwing cipher and asserts login finishes withINTERNAL_ERROR.Related: #189.