Drop non-plist glyph libs instead of failing#382
Merged
Conversation
anthrotype
approved these changes
Nov 27, 2025
Collaborator
anthrotype
left a comment
anthrotype
left a comment
There was a problem hiding this comment.
a warning about the malformed data would still be nice
These exist in a number of old real-world UFO files, and it doesn't seem particularly useful to just fail to read those files at all. This also brings in the log crate, for logging these dropped errors.
cmyr
force-pushed
the
skip-non-plist-glyph-lib
branch
from
39dbf68 to
769df04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These exist in a number of old real-world UFO files, and it doesn't seem particularly useful to just fail to read those files at all.