Skip to content

feat(core): Add global formats options for setupI18n#2291

Draft
DeyLak wants to merge 1 commit into
lingui:main-renamedfrom
DeyLak:feat/global-formats
Draft

feat(core): Add global formats options for setupI18n#2291
DeyLak wants to merge 1 commit into
lingui:main-renamedfrom
DeyLak:feat/global-formats

Conversation

@DeyLak

@DeyLak DeyLak commented Jul 22, 2025

Copy link
Copy Markdown

Description

This PR resolves part of the discussed changes in #2279. It adds an opportunity configure formats as an optional parameter in setupI18n

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #2279

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel

vercel Bot commented Jul 22, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Jul 22, 2025 0:39am

@codecov

codecov Bot commented Jul 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.84%. Comparing base (6bb8983) to head (d92ba2b).
⚠️ Report is 265 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
- Coverage   77.05%   76.84%   -0.22%     
==========================================
  Files          84       89       +5     
  Lines        2157     2500     +343     
  Branches      555      651      +96     
==========================================
+ Hits         1662     1921     +259     
- Misses        382      463      +81     
- Partials      113      116       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DeyLak

DeyLak commented Jul 22, 2025

Copy link
Copy Markdown
Author

I'm not sure, why the docs-suite/validate is failing. As far as I can see, there is not such command as yarn checkFormat. I've run yarn lint:all and yarn release:test to check formatting

@timofei-iatsenko

Copy link
Copy Markdown
Collaborator

@DeyLak /website folder has it's own package.json file with it's own commands. Had to be run from there

@andrii-bodnar andrii-bodnar marked this pull request as draft January 26, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom formatters for numbers, dates etc.

2 participants