fix(core): add bigint to MessagePlaceholder type#2507
Open
pkasarda wants to merge 1 commit into
Open
Conversation
|
@pkasarda is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
Libraries like Zod use `bigint` for validation bounds (e.g. `minimum: number | bigint` on `ZodTooSmallIssue`). Passing these values to `t` template literals currently requires wrapping in `Number()`. Adding `bigint` to `MessagePlaceholder` allows these values to be passed directly, consistent with `i18n._()` which already accepts `Record<string, unknown>`.
pkasarda
force-pushed
the
fix/message-placeholder-bigint-undefined
branch
from
563d052 to
04f486c
Compare
pkasarda
changed the title
8 tasks
Collaborator
|
Related #2502 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-renamed #2507 +/- ##
===============================================
Coverage ? 81.21%
===============================================
Files ? 104
Lines ? 2720
Branches ? 725
===============================================
Hits ? 2209
Misses ? 364
Partials ? 147 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Libraries like Zod type validation bounds as
number | bigint(e.g.ZodTooSmallIssue.minimum: number | bigint). Passing these values directly inttemplate literals causes a TypeScript error:Solution
Add
bigintto theMessagePlaceholdertype in@lingui/core/macro:This is consistent with
i18n._()which already acceptsValues = Record<string, unknown>.Workaround users currently need
With this fix: