fix: don't warn about missing id when a spread is present#2581
Open
mogelbrod wants to merge 1 commit into
Open
fix: don't warn about missing id when a spread is present#2581mogelbrod wants to merge 1 commit into
mogelbrod wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
===========================================
+ Coverage 77.05% 89.79% +12.74%
===========================================
Files 84 124 +40
Lines 2157 3695 +1538
Branches 555 1110 +555
===========================================
+ Hits 1662 3318 +1656
+ Misses 382 339 -43
+ Partials 113 38 -75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code like below currently triggers a "Missing message ID, skipping" warning on
lingui extract, even though it works and is a decent workaround to use placeholders in lazy lookups:I'd like to propose that we stop reporting missing IDs when a spread is also present in the object passed to the
i18n._call.If this is accepted I'll happily provide patches for the experimental extractor along with the SWC extractor.
Types of changes
Checklist