feat: add pseudolocalize options#2583
Open
ThibaultJanBeyer wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
timofei-iatsenko
requested changes
Jun 26, 2026
| export { makeConfig } from "./makeConfig" | ||
| export { defineConfig } from "./defineConfig" | ||
| export { getConfig } from "./getConfig" | ||
| export { getPseudoLocale, getPseudoLocaleOptions } from "./getPseudoLocale" |
Collaborator
There was a problem hiding this comment.
i suggest not export that from the package, but instead apply and normalize config in the makeConfig. So all consumers would receive normalized (expanded) option
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
===========================================
+ Coverage 77.05% 89.75% +12.69%
===========================================
Files 84 125 +41
Lines 2157 3698 +1541
Branches 555 1112 +557
===========================================
+ Hits 1662 3319 +1657
+ Misses 382 341 -41
+ Partials 113 38 -75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current pseudolocalization doesn't allow for padding to catch UI bugs caused by longer languages.
Here is the related issue: #2582
Types of changes
The signature of the
pseudoLocalecan now look either like this:or like this:
Fixes #2582
Checklist
(I'm not sure, added it to website/docs/ref/conf.md. Somewhere else to add?