Skip to content

time handling might be wrong #110

Description

@derhuerst

I stumbled upon this because, when building gtfs-utils, I identifed this as a bug: GTFS Time values are defined relative to "12 hours before noon", so the implementation in this repo seems to fail during DST switches.

const addDuration = function (date, duration) {
return addSeconds(addMinutes(addHours(date, duration.hours), duration.minutes), duration.seconds);
}


related: google/transit#15

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions