Create typingAttributesSetByApp to restore textView typingAttributes#222
Open
rcancro wants to merge 2 commits intolinkedin:masterfrom
Open
Create typingAttributesSetByApp to restore textView typingAttributes#222rcancro wants to merge 2 commits intolinkedin:masterfrom
rcancro wants to merge 2 commits intolinkedin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into issues where after a mention is detected, my textView's
typingAttributesare not used.Looking at the code, it appears that after inserting a mention, the
typingAttributesget recreated viastripCustomAttributesFromTypingAttributes. This method takes the currenttypingAttributesand removes all keys that are also inmentionUnselectedAttributes. It then tries to recreatetypingAttributesby usingfontSetByAppandtextColorSetByApp.My code never set these values, and instead was only using
typingAttributes. After a mention was created, the font and foreground attributes would be removed bystripCustomAttributesFromTypingAttributes, leaving my textView with notypingAttributes.This is a simple change to also keep track of
typingAttributesSetByApp. If intypingAttributesByStrippingMentionAttributes:we see thattypingAttributesSetByAppis non-nil, we return those. Otherwise we fall back onfontSetByAppandtextColorSetByApp.