Skip to content

Create typingAttributesSetByApp to restore textView typingAttributes#222

Open
rcancro wants to merge 2 commits intolinkedin:masterfrom
rcancro:typingAttributes
Open

Create typingAttributesSetByApp to restore textView typingAttributes#222
rcancro wants to merge 2 commits intolinkedin:masterfrom
rcancro:typingAttributes

Conversation

@rcancro
Copy link
Copy Markdown
Contributor

@rcancro rcancro commented Nov 25, 2020

I was running into issues where after a mention is detected, my textView's typingAttributes are not used.

Looking at the code, it appears that after inserting a mention, the typingAttributes get recreated via stripCustomAttributesFromTypingAttributes. This method takes the current typingAttributes and removes all keys that are also in mentionUnselectedAttributes. It then tries to recreate typingAttributes by using fontSetByApp and textColorSetByApp.

My code never set these values, and instead was only using typingAttributes. After a mention was created, the font and foreground attributes would be removed by stripCustomAttributesFromTypingAttributes, leaving my textView with no typingAttributes.

This is a simple change to also keep track of typingAttributesSetByApp. If in typingAttributesByStrippingMentionAttributes: we see that typingAttributesSetByApp is non-nil, we return those. Otherwise we fall back on fontSetByApp and textColorSetByApp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant