Logging failures to refresh metadata#385
Merged
cbb330 merged 1 commit intolinkedin:mainfrom Oct 27, 2025
Merged
Conversation
abhisheknath2011
approved these changes
Oct 27, 2025
Member
abhisheknath2011
left a comment
There was a problem hiding this comment.
Thanks @cbb330 for adding logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
problem - when an exception throws under
super.refreshFromMetadataLocation, there is no failure log which shows how long it took to fail. Adding logging here for the total duration Helps us measure how long a request takes when it fails to retrieve metadata from hdfs. This is a common cause for 504 gateway timeouts. Without this, we can only guess the total duration by correlating it with metrics. The metrics don’t have a failure/success dimension, and also cannot be isolated to a single request/table metadata file.solution - try/catch and log before throwing the existing error. There is another PR which aims to reduce the total duration via better configured timeouts+retries at hdfs layer #386
At the same time, adding a missing log message for catalog update, for future operations
Changes
Testing Done
existing tests should cover this
Additional Information