tables: expose loggers actuator endpoint for dynamic log level control#508
Open
cbb330 wants to merge 1 commit intolinkedin:mainfrom
Open
tables: expose loggers actuator endpoint for dynamic log level control#508cbb330 wants to merge 1 commit intolinkedin:mainfrom
cbb330 wants to merge 1 commit intolinkedin:mainfrom
Conversation
Adds the Spring Boot Actuator /actuator/loggers endpoint to the tables-service, enabling dynamic log level changes at runtime without pod restarts or deployment changes. This supports the hdfs-diagnostics tooling: enable-hdfs-debug.sh uses this endpoint to activate DEBUG logging on a single pod during incident windows, mirroring the loggers configured in application-hdfs-diagnostics.properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Spring Boot Actuator
/actuator/loggersendpoint to the tables-service, enabling dynamic log level changes at runtime without pod restarts or deployment changes.Changes
Added to
services/tables/src/main/resources/application.properties:This exposes
POST /actuator/loggers/{name}to set any logger to DEBUG (or reset it) on a live pod without restarting. Intended for incident use to activate targeted diagnostic logging — for example the loggers inapplication-hdfs-diagnostics.properties— on a single replica without modifying the deployment or replicaset.Testing Done
Local bootRun:
Test cluster:
Deployed to the test cluster via internal build. Verified from inside the running pod:
{ "loggers-name": {"href": "http://localhost:8080/actuator/loggers/{name}", "templated": true}, "loggers": {"href": "http://localhost:8080/actuator/loggers", "templated": false} }All log levels (OFF, FATAL, ERROR, WARN, INFO, DEBUG, TRACE) available via
GET /actuator/loggers.Why no new tests: Configuration-only change (
application.properties). The actuator auto-configuration is covered by Spring Boot's own test suite; no functional code paths were modified.Additional Information