[server][dvc] Add blob transfer send/receive byte rate metric at both version level and host level #2338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixpluszero
force-pushed
the
blobTransferTrafficMetric
branch
from
615e1b9 to
ebf4cf1
Compare
sixpluszero
force-pushed
the
blobTransferTrafficMetric
branch
from
ebf4cf1 to
994aa20
Compare
jingy-li
reviewed
Jan 20, 2026
| package com.linkedin.davinci.stats; | ||
|
|
||
| public class AggBlobTransferStats { | ||
| private final AggVersionedBlobTransferStats aggVersionedBlobTransferStats; |
Contributor
There was a problem hiding this comment.
Let’s add some Javadoc here. Also, could you include the Kafka stats it will be compared against?
Contributor
There was a problem hiding this comment.
Could you also add doc that aggVersionedBlobTransferStats reports speed, time, and success/failure counts, and aggHostLevelIngestionStats reports bytes accumulation?
Contributor
Author
There was a problem hiding this comment.
Yeah good callout, updated the java doc.
|
|
||
| // The blob file receiving throughput (in MB/sec) and time (in sec) | ||
| protected static final String BLOB_TRANSFER_THROUGHPUT = "blob_transfer_file_receive_throughput"; | ||
| protected static final String BLOB_TRANSFER_TIME = "blob_transfer_time"; |
Contributor
There was a problem hiding this comment.
qq, do you think we need to remove the BLOB_TRANSFER_THROUGHPUT graph, I can cut a separate PR to remove it.
Contributor
Author
There was a problem hiding this comment.
I think so. But maybe let's first verify this metric is working and we can deprecate the old one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[server][dvc] Add blob transfer send/receive byte rate metric at both version level and host level
This PR adds rate metric for blob transfer send and receive activity for more observability in the ingestion path.
It will give host level send/receive byte rate, as well as version level send/receive byte rate. With this, we can easily monitor how system is doing the blob transfer from/to other peer nodes.
Solution
Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized,RWLock) are used where needed.ConcurrentHashMap,CopyOnWriteArrayList).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?