fix: preserve shutdown mode when readiness checks are disabled - #571
Open
immanuwell wants to merge 1 commit into
Open
fix: preserve shutdown mode when readiness checks are disabled#571immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #20.
LINKERD_AWAIT_DISABLEDis meant to skip readiness checks, but it also skipped--shutdown. Kinda sneaky. For jobs and cronjobs that means the child can exit, but the proxy never gets/shutdown.This patch keeps the disable env scoped to readiness checks only, and adds a regression test for it.
Repro:
4191and countPOST /shutdown.LINKERD_AWAIT_DISABLED=1 linkerd-await --shutdown -- /bin/true.0.1.