Skip to content

fix: remove watching resources and change to reconciling loop#320

Open
CasLubbers wants to merge 10 commits intomainfrom
APL-1417-refactoring-9
Open

fix: remove watching resources and change to reconciling loop#320
CasLubbers wants to merge 10 commits intomainfrom
APL-1417-refactoring-9

Conversation

@CasLubbers
Copy link
Contributor

No description provided.

@CasLubbers CasLubbers changed the title Apl 1417 refactoring 9 fix: remove watching resources and change to reconciling loop Mar 2, 2026
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
40.4% (+0.54% 🔼)
625/1547
🔴 Branches
28.51% (+1.39% 🔼)
142/498
🔴 Functions
26.38% (+0.95% 🔼)
62/235
🔴 Lines
41.49% (+0.84% 🔼)
590/1422
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / oidc.ts
9.68% 0% 0% 11.54%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / harbor.ts
48.05% (+12.85% 🔼)
50% (+29.49% 🔼)
10% (-2.5% 🔻)
50% (+12.71% 🔼)
🟢
... / harbor-project.ts
84.31% (-6.86% 🔻)
61.11% (-1.39% 🔻)
100%
87.76% (-2.24% 🔻)
🟡
... / harbor-robots.ts
68.25% (-0.25% 🔻)
66.18% 85.71%
70% (-0.25% 🔻)

Test suite run success

49 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 4a04ba7

@ElderMatt ElderMatt marked this pull request as ready for review March 2, 2026 14:25
@ElderMatt ElderMatt self-requested a review as a code owner March 2, 2026 14:25
function hasStateChanged(currentState: HarborState, _lastState: HarborState): boolean {
return Object.entries(currentState).some(([key, value]) => !value || value !== _lastState[key])
let reconciling = false
interface HarborApis {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants