-
Notifications
You must be signed in to change notification settings - Fork 15
Add support for Linode Interfaces #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add support for Linode Interfaces * Add Linode Interface example * Address comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for newer Linode network interfaces alongside the existing legacy config interfaces. The implementation introduces a new linode_interface configuration block with comprehensive support for public, VPC, and VLAN interface types, while maintaining backward compatibility with the existing interface configuration.
Key Changes:
- Added new
LinodeInterfacestruct and related types for public, VPC, and VLAN interface configurations - Implemented interface generation selection via
interface_generationfield - Added flattening functions to convert Packer configuration to Linode API options
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| builder/linode/linode_interfaces.go | Defines new interface configuration structures for Linode networking |
| builder/linode/linode_interfaces.hcl2spec.go | Auto-generated HCL2 specification for new interface types |
| builder/linode/step_create_linode.go | Implements flattening logic and updates instance creation to support both interface types |
| builder/linode/config.go | Adds LinodeInterfaces and InterfaceGeneration configuration fields |
| builder/linode/config.hcl2spec.go | Updates HCL2 spec to include new configuration fields |
| builder/linode/builder_test.go | Adds comprehensive tests for Linode interface configuration |
| docs/builders/linode.mdx | Documents new interface configuration options with examples |
| .web-docs/components/builder/linode/README.md | Updates generated documentation for new interface support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
yec-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🎉
Merge from project branch to dev. This is basically same as #337, which has been reviewed and approved
Testing
go test ./builder/linode -run TestBuilderPrepare_LinodeNetworkInterfacesPut this content in a file called
test.pkr.hclThan run: