syscall_module: Use a kernel module that is present by default#125
Open
infinisil wants to merge 1 commit intolinux-audit:mainfrom
Open
syscall_module: Use a kernel module that is present by default#125infinisil wants to merge 1 commit intolinux-audit:mainfrom
infinisil wants to merge 1 commit intolinux-audit:mainfrom
Conversation
Since 6.13, the arp_tables module is not available in the default kernel config anymore, so let's use a different module, because the test doesn't need any specific one
|
I wonder whether we can instead locate a not-loaded-but-available kernel module automatically to prevent similar issues in the future? That of course risks a broken module being found by whatever heuristic introduced to get a loadable kernel module, so maybe just delaying this problem to some unknown future time is fine. |
Contributor
|
I wonder whether we can instead locate a not-loaded-but-available kernel module automatically to prevent similar issues in the future? That of course risks a *broken* module being found by whatever heuristic introduced to get a loadable kernel module, so maybe just delaying this problem to some unknown future time is fine.
I've had the same thoughts and concerns since I first wrote the test. "sg" is as good as any, but still subject to uncertainty.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 6.13, the arp_tables module is not available in the default kernel config anymore, so let's use a different module, because the test doesn't need any specific one.
Tested in Nix by adjusting NixOS/nixpkgs#465550