Hybrid transport runtime errors fixes#127
Merged
Merged
Conversation
AlfioEmanueleFresta
added a commit
that referenced
this pull request
Jul 21, 2025
Requires #127. Changes: * Refactors Hybrid (caBLE) connection stages into 3 reusable components * Move all 3 connection stages to the channel handle, in addition to existing connection handler * Operations first wait for a connection to be established, then perform the operation with the operation timeout Next steps: * Surface errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Tungstenite now requiring selecting a crypto provider
A panic at runtime when attempting to establish a secure WebSocket connection:
For more details, see:
CryptoProvidersnapview/tokio-tungstenite#353This is now fixed by explicitly selecting
rustlsas thetungsteniteTLS backend, as recommended intokio-tungstenite.2. Hybrid initial GetInfo deserialization fails
An error deserializing the caBLE initial message containing the GetInfo response:
This was accidentally introduced in #110: https://github.com/linux-credentials/libwebauthn/pull/110/files#diff-d061af4011a3c577c5c2dbef3b1933b0e8c8a9ebc0bf70a0ebc3358e890ed725R587
Fixed by using the appropriate serialization method.