Implement NFC#152
Merged
AlfioEmanueleFresta merged 10 commits intoOct 29, 2025
Merged
Conversation
AlfioEmanueleFresta
approved these changes
Oct 16, 2025
AlfioEmanueleFresta
left a comment
Member
There was a problem hiding this comment.
Thank you very much for picking this up @msirringhaus!
Member
This seems a reasonable approach. If in the future multiple backends scenarios arise, contributions to make this configurable will be welcome! |
- Create separate NFC-examples. Only compile them if NFC-features are requested - Only return the first found NFC-device - Remove left-over todo!()-macro call
Member
|
Thank you very much @msirringhaus, this looks great! |
AlfioEmanueleFresta
approved these changes
Oct 29, 2025
604b53b
into
linux-credentials:master
3 checks passed
This was referenced Dec 27, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very heavily based on #105, with the following additions:
select_fido2()to discover both U2F and FIDO2-only devicesNfcDevicederiveCloneand other minor tweaks, so we can easily use it incredentialsdOpen questions:
credentialsduses a poll-mechanism to find USB-devices (simply looping overlist_devices()) as well, I did not investigate to get a blocking device discovery.hidwithnfcin the USB-handler. Thus, I needed a dummyblink_and_wait_for_user_presence()-implementation. This should probably be removed, esp. if we go for the "return first device"-scheme mentioned above. But doing that, I was able to successfully use NFC-devices with Firefox.