fix(ctap2): feature-detect credProtect from getInfo#273
Merged
Conversation
…forcing policy The enforcement gate keyed off is_uv_protected, which reports whether a PIN or built-in UV is configured rather than whether the authenticator implements credProtect. Detect the extension from the getInfo extensions array instead. This refuses authenticators that would silently drop an enforced policy and stops rejecting credProtect-capable authenticators that have no PIN or UV set yet.
AlfioEmanueleFresta
force-pushed
the
fix/credprotect-feature-detect
branch
from
23216b6 to
06793c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a relying party requires a credential protection policy, the client must refuse an authenticator that cannot honor it. The check looked at user verification state, which says nothing about credProtect support. This feature-detects credProtect from the authenticator getInfo and enforces the policy against that.
Closes #253.