Split extensions into unsigned extensions and signed extensions inside AuthenticatorData#99
Merged
msirringhaus merged 4 commits intoMay 9, 2025
Conversation
AlfioEmanueleFresta
approved these changes
May 8, 2025
Collaborator
Author
|
I only renamed one function, which was quite generic and unclear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impl Serialize for AttestedCredentialDataandimpl<T> Serialize for AuthenticatorData<T>actually doesn't work the way it was intended, because it needs to be wrapped inside some other data type, that we don't have. So I moved that code to a stand-alone function that returns theVec<u8>directly.