Skip to content

test: remove unused files#335

Merged
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-remove-unused
Jun 24, 2026
Merged

test: remove unused files#335
richm merged 1 commit into
linux-system-roles:mainfrom
richm:test-remove-unused

Conversation

@richm

@richm richm commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

We do not use molecule.

The custom requirements are no longer needed.

Remove py26 requirements

Use ansible-core instead of ansible - much smaller

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by CodeRabbit

  • Chores
    • Removed several empty or placeholder configuration files and comments.
    • Simplified dependency declarations by dropping outdated compatibility entries.
    • Cleaned up test environment setup files that are no longer needed.

@richm richm requested review from rjeffman and spetrosi as code owners June 24, 2026 15:15
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ba9d1e7-0f85-488e-a572-69df06d053ed

📥 Commits

Reviewing files that changed from the base of the PR and between 84ed69a and abc40ad.

📒 Files selected for processing (5)
  • ansible_pytest_extra_requirements.txt
  • custom_requirements.txt
  • molecule/default/Dockerfile.j2
  • molecule/default/molecule.yml
  • molecule_extra_requirements.txt
💤 Files with no reviewable changes (4)
  • molecule/default/molecule.yml
  • custom_requirements.txt
  • molecule/default/Dockerfile.j2
  • molecule_extra_requirements.txt

📝 Walkthrough

Walkthrough

The PR replaces the ansible dependency with ansible-core in ansible_pytest_extra_requirements.txt, removes old pinned conditional dependencies, clears placeholder content from custom_requirements.txt and molecule_extra_requirements.txt, and deletes the molecule/default/Dockerfile.j2 and molecule/default/molecule.yml files entirely.

Changes

Dependency and Molecule cleanup

Layer / File(s) Summary
Switch ansible to ansible-core; remove molecule scenario
ansible_pytest_extra_requirements.txt, custom_requirements.txt, molecule_extra_requirements.txt, molecule/default/Dockerfile.j2, molecule/default/molecule.yml
ansible is replaced with ansible-core under the same python_version > "2.6" marker; old pinned conditional extras (idna<2.8, PyYAML<5.1) are dropped; SPDX/comment-only content is removed from requirement stubs; the full molecule default scenario (Dockerfile template, platform config, provisioner, and test sequence) is deleted.
🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description lacks the required template sections and headings for Enhancement, Reason, Result, and Issue Tracker Tickets. Rewrite the description using the repository template and fill in each required section, including issue tracker ticket references if any.
Description Format ⚠️ Warning Repo template requires Enhancement/Reason/Result, but the PR description only has prose plus Signed-off-by and omits those sections. Rewrite the PR description to include Enhancement:, Reason:, and Result: headings (Issue Tracker Tickets optional).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses Conventional Commits format and accurately summarizes the change to remove unused test-related files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

We do not use molecule.

The custom requirements are no longer needed.

Remove py26 requirements

Use ansible-core instead of ansible - much smaller

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the test-remove-unused branch from 633ae58 to abc40ad Compare June 24, 2026 15:38
@richm richm merged commit 101e680 into linux-system-roles:main Jun 24, 2026
36 of 38 checks passed
@richm richm deleted the test-remove-unused branch June 24, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant