Skip to content

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#298

Merged
richm merged 1 commit intomainfrom
ci-container-improvements
Mar 11, 2026
Merged

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#298
richm merged 1 commit intomainfrom
ci-container-improvements

Conversation

@richm
Copy link
Collaborator

@richm richm commented Mar 11, 2026

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use newer tox-lsr and Ansible versions and optimize container test execution.

Build:

  • Bump tox-lsr dependency from 3.16.0 to 3.17.0 across GitHub Actions workflows.

CI:

  • Update Fedora 43 qemu and container test matrix entries to use Ansible Core 2.20.
  • Adjust container test job to run the first test with full requirements and callback plugins enabled, then skip them for subsequent tests to speed up execution.

…r fedora 43 [citest_skip]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm self-assigned this Mar 11, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, and adjusts container test env vars to leverage new tox-lsr behavior for faster, clearer container runs.

Flow diagram for qemu_kvm_integration_tests workflow with tox_lsr_3_17_0 and Ansible_2_20

flowchart TD
  trigger[Push or pull_request event] --> gha_runner[GitHub Actions runner]
  gha_runner --> checkout[Checkout repository]
  checkout --> setup_python[Set up Python environment]
  setup_python --> install_tox_lsr[Install tox-lsr 3.17.0 via pip]
  install_tox_lsr --> configure_env[Configure container and qemu test env vars]
  configure_env --> run_tox[Run tox for qemu/container envlist]
  run_tox --> tox_lsr_core[tox-lsr 3.17.0 core logic]
  tox_lsr_core --> launch_fedora43[Launch Fedora 43 container or VM]
  launch_fedora43 --> install_ansible_2_20[Install Ansible 2.20 in test environment]
  install_ansible_2_20 --> execute_tests[Execute Ansible role tests]
  execute_tests --> collect_output[Collect improved container test output]
  collect_output --> finish[Publish results and complete workflow]
Loading

File-Level Changes

Change Details Files
Bump tox-lsr from 3.16.0 to 3.17.0 across CI workflows.
  • Update qemu-kvm integration workflow to install tox-lsr 3.17.0 via pip
  • Update ansible-lint workflow to install tox-lsr 3.17.0
  • Update ansible-managed-var-comment workflow to install tox-lsr 3.17.0
  • Update ansible-test workflow to install tox-lsr 3.17.0
  • Update python-unit-test workflow to install tox-lsr 3.17.0
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/python-unit-test.yml
Use Ansible 2.20 for Fedora 43 qemu and container scenarios in integration tests.
  • Change Fedora 43 qemu env from qemu-ansible-core-2-19 to qemu-ansible-core-2-20
  • Change Fedora 43 container env from container-ansible-core-2-19 to container-ansible-core-2-20
  • Change Fedora 43 bootc container env from container-ansible-core-2-19 to container-ansible-core-2-20
.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop to control new tox-lsr behavior via environment flags for requirements and callback plugins.
  • Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides from container test step
  • Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS env vars, forcing them false for the first test run
  • Enable SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS for subsequent tests within the loop to speed up runs
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 66c70c2 into main Mar 11, 2026
14 checks passed
@richm richm deleted the ci-container-improvements branch March 11, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant