ci: rollout several recent changes to CI testing - #137
Merged
Conversation
* Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
* Use tox-lsr version 3.11.1
* Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
* Update contributing.md documentation
* Update number of nodes to use in testing farm, if needed
* remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR refines the CI testing setup by passing the __bootc_validation flag as a YAML boolean, upgrading tox-lsr to 3.11.1 across workflows, broadening cancellation detection in the citest bad workflow, and enriching the contributing guide with local CI test instructions. Sequence diagram for citest bad workflow handling cancelled and failed runssequenceDiagram
participant "GitHub Actions Workflow"
participant "GitHub API"
participant "Test Farm (TF)"
"GitHub Actions Workflow"->>"GitHub API": Query workflow runs for PR title
"GitHub API"-->>"GitHub Actions Workflow": Return runs with conclusion (failure or cancelled)
"GitHub Actions Workflow"->>"Test Farm (TF)": Process failed or cancelled run
"Test Farm (TF)"-->>"GitHub Actions Workflow": Return status
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Use tox-lsr version 3.11.1
Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
Update contributing.md documentation
Update number of nodes to use in testing farm, if needed
remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Roll out recent improvements to CI testing by bumping tox-lsr, correctly passing boolean variables, handling cancelled test runs, cleaning up lint skips, and enhancing local test documentation
Bug Fixes:
Enhancements:
Documentation: