Skip to content

chore: update changelog to 6.1.77#1048

Merged
fly602 merged 1 commit intolinuxdeepin:masterfrom
mhduiy:dev-changelog-6.1.77
Mar 5, 2026
Merged

chore: update changelog to 6.1.77#1048
fly602 merged 1 commit intolinuxdeepin:masterfrom
mhduiy:dev-changelog-6.1.77

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Mar 5, 2026

更新说明

自动更新 changelog 到版本 6.1.77

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 6.1.77
  • 目标分支: master

Summary by Sourcery

Chores:

  • Refresh Debian changelog entry to reflect new 6.1.77 release targeting master.

update changelog to 6.1.77

Log: update changelog to 6.1.77
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 5, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian changelog to reflect a new release version 6.1.77 targeting master, with no code or configuration changes outside the changelog metadata.

File-Level Changes

Change Details Files
Bump project version metadata in the Debian changelog to 6.1.77 for a new release.
  • Add or update the top changelog entry to version 6.1.77
  • Ensure the entry notes the automatic changelog update for this release
  • Confirm target branch information aligns with master for this version entry
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

TAG Bot

TAG: 6.1.77
EXISTED: no
DISTRIBUTION: unstable

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

这份 debian/changelog 的 diff 记录了 dde-daemon 从版本 6.1.76 升级到 6.1.77 的变更。从变更日志来看,这次更新主要集中在安全性修复、特定架构的显示问题修复以及功能移除上。

以下是对该变更日志的详细审查意见,分为语法逻辑、代码质量、代码性能和代码安全四个方面:

1. 语法逻辑

  • 格式规范性
    • 该 diff 符合 Debian changelog 的标准格式(遵循 DEP-3 标准),包括包名、版本号、发行版、紧急程度以及维护者信息。
    • 每一条变更条目前都有明确的 * 前缀,缩进正确。
    • 时间戳格式 Thu, 05 Mar 2026 20:43:23 +0800 符合 RFC 2822 标准。
  • 语言一致性
    • 问题:日志中混合使用了英文和中文。
      • 英文示例:refactor(accounts1): remove guest user functionality
      • 中文示例:fix: 修复usb手写屏热插拔不生效问题
    • 建议:为了保持专业性,建议统一使用英文编写变更日志。如果项目主要受众是中文开发者,且团队规范允许使用中文,那么建议统一使用中文。混合使用会降低日志的可读性和可维护性。
  • 拼写与术语
    • "arm64, loongarch64, and sw64" 架构名称拼写正确,符合 Linux 内核和 Debian 的命名规范。
    • "EDID" (Extended Display Identification Data) 术语使用正确。

2. 代码质量

  • 重构
    • refactor(accounts1): remove guest user functionality:明确说明了移除了访客用户功能。这通常意味着代码库中减少了维护负担,但也需确保相关的 UI 组件和依赖项已同步移除,避免出现死代码或引用错误。
  • Bug 修复的具体性
    • fix(grub): Replace DeepinGfxmodeNotSupported mechanism with EDID hash caching:这条日志非常棒。它不仅说明了修复了什么,还简要说明了实现方案(用 EDID 哈希缓存替换旧机制),这有助于代码审查者理解修改的范围和逻辑。
    • fix: 优化了音频逻辑(上一版本):相比之下,上一版本的日志过于模糊。新版本中的日志大多提供了具体的上下文(如 "due to security check race condition"),质量较高。

3. 代码性能

  • EDID 哈希缓存
    • fix(grub): ... with EDID hash caching:引入缓存机制通常是为了解决重复读取硬件信息导致的性能问题或启动延迟。这是一个积极的性能优化方向,建议在代码审查中确认缓存失效策略是否正确(例如,当显示器更换时缓存是否能及时更新)。
  • 移除功能
    • refactor(accounts1): remove guest user functionality:移除功能通常会减少运行时的内存占用和潜在的进程开销,对性能有微小的正面影响。

4. 代码安全

这是本次更新中最值得关注的领域,涉及多个关键的安全修复:

  • 密码泄露与竞态条件
    • fix: prevent password leakage in ModifyPasswd:这是一个严重的安全修复。建议审查 ModifyPasswd 函数,确保密码在内存中处理完毕后被及时清零(例如使用 memset_s 或类似机制),且不会通过日志、core dump 或环境变量泄露。
    • refactor(accounts): disable UnionID password setting due to security check race condition:因竞态条件禁用功能,说明原有的并发控制存在缺陷。建议审查是否可以通过加锁或其他同步机制来安全地重新启用该功能,而不是永久禁用。
  • 权限提升与目录劫持
    • fix: prevent local root exploit via directory hijacking:这是一个高危漏洞修复。目录劫持通常涉及对临时目录或可写目录的不当处理。审查重点应放在文件操作前的权限检查(遵循 TOCTOU 原则)以及对符号链接的处理上。
  • 符号链接攻击
    • fix: prevent symlink attack in removeLoginKeyring:符号链接攻击常用于覆盖系统文件。修复建议:确保在删除或操作文件前,检查目标路径是否为符号链接,或者在操作时使用 O_NOFOLLOW 标志(如果适用),或者确保操作在受限的安全目录中进行。

总结与改进建议

  1. 统一日志语言:强烈建议将所有中文条目翻译成英文,以符合国际开源项目的惯例。
    • fix: 修复usb手写屏热插拔不生效问题 -> fix(input): fix USB touchscreen hotplug not working
    • fix: 解决低电量进入系统后, 系统触发的节能模式, 电量没有变化的问题 -> fix(power): fix battery level not updating when entering power saving mode
  2. 安全审查:鉴于本次更新包含多个安全补丁(密码泄露、目录劫持、符号链接攻击),建议在合并代码前进行专门的安全审计,确保修复方案彻底,没有引入新的漏洞。
  3. 时间戳检查:diff 中的日期是 2026 年,请确认这是否为笔误或测试环境的时间设置。如果是笔误,应修正为当前年份(如 2024 或 2025),以免造成版本管理的混乱。

总体而言,这是一份质量较高的变更日志,尤其是安全相关的修复描述得比较清晰,但在语言规范性和细节描述上仍有优化空间。

@fly602 fly602 merged commit 5d5202d into linuxdeepin:master Mar 5, 2026
17 of 19 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 5, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.1.77
  • Tag SHA: a6099b61e81f77be04cf44cff12b280fa2b6d32a
  • Commit SHA: abee5ea06920620f939408e64115098493e12fb1
  • Tag Message:
    Release dde-daemon 6.1.77
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants