Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (broader_impact): The wakeup sound is played unconditionally, so suspend resume still produces audio when the system's
enable-event-soundssetting is false. This bypasses the existing system sound-effects preference and contradicts the stated behavior that the sound plays only when sound effects are enabled.Triggers: When the user has disabled system event sounds.
Suggested fix: Check the effective
enable-event-soundssetting before launchingpaplay, or route the event through the existing sound-effect service that enforces this preference.