Skip to content

feat: add pam_deepin_keyring support to PAM services - #117

Merged
Groveer merged 1 commit into
linuxdeepin:masterfrom
wineee:pam
Oct 15, 2026
Merged

Groveer merged 1 commit into
linuxdeepin:masterfrom
wineee:pam

Conversation

@wineee

@wineee wineee commented Oct 15, 2026 •

Copy link
Copy Markdown
Member
  1. Add pam_deepin_keyring to auth and session stacks in ddm.pam
  2. Add pam_deepin_keyring to auth and session stacks in debian.ddm.pam
  3. Add pam_deepin_keyring to ddm-autologin.pam for passwordless login
  4. Recommend deepin-keyring-whitebox package in debian/control

Log: No user-facing changes

Influence:

  1. Verify normal password login unlocks the keyring without error
  2. Verify autologin and nopasswdlogin unlock the keyring seamlessly
  3. Verify login still works when deepin-keyring-whitebox is not installed

feat: 为 PAM 服务增加 pam_deepin_keyring 支持

  1. 在 ddm.pam 的 auth 和 session 栈中加入 pam_deepin_keyring
  2. 在 debian.ddm.pam 的 auth 和 session 栈中加入 pam_deepin_keyring
  3. 在 ddm-autologin.pam 中加入 pam_deepin_keyring 以支持免密登录
  4. 在 debian/control 中推荐安装 deepin-keyring-whitebox 包

Log: 无用户可见变化

Influence:

  1. 验证正常密码登录后密钥环能被解锁且无报错
  2. 验证自动登录和免密登录时密钥环能正常解锁
  3. 验证未安装 deepin-keyring-whitebox 时登录仍能正常进行

PMS: TASK-390751

Summary by Sourcery

Integrate pam_deepin_keyring into DDM PAM services so keyrings unlock across supported login flows while remaining optional for successful login.

New Features:

  • Enable Deepin keyring support across password, session, autologin, and nopasswdlogin PAM flows.

Build:

  • Recommend the deepin-keyring-whitebox package as a dependency.

1. Add pam_deepin_keyring to auth and session stacks in ddm.pam
2. Add pam_deepin_keyring to auth and session stacks in debian.ddm.pam
3. Add pam_deepin_keyring to ddm-autologin.pam for passwordless login
4. Recommend deepin-keyring-whitebox package in debian/control

Log: No user-facing changes

Influence:
1. Verify normal password login unlocks the keyring without error
2. Verify autologin and nopasswdlogin unlock the keyring seamlessly
3. Verify login still works when deepin-keyring-whitebox is not installed

feat: 为 PAM 服务增加 pam_deepin_keyring 支持

1. 在 ddm.pam 的 auth 和 session 栈中加入 pam_deepin_keyring
2. 在 debian.ddm.pam 的 auth 和 session 栈中加入 pam_deepin_keyring
3. 在 ddm-autologin.pam 中加入 pam_deepin_keyring 以支持免密登录
4. 在 debian/control 中推荐安装 deepin-keyring-whitebox 包

Log: 无用户可见变化

Influence:
1. 验证正常密码登录后密钥环能被解锁且无报错
2. 验证自动登录和免密登录时密钥环能正常解锁
3. 验证未安装 deepin-keyring-whitebox 时登录仍能正常进行

PMS: TASK-390751
@sourcery-ai

sourcery-ai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PAM service definitions now invoke pam_deepin_keyring across normal, Debian-specific, autologin, and passwordless login paths, while packaging recommends deepin-keyring-whitebox so keyring integration is available without preventing login when the package is absent.

File-Level Changes

Change Details Files
Integrate the Deepin keyring PAM module into password, session, and passwordless authentication flows.
  • Add the module to authentication and session stacks for standard DDM services.
  • Add the module to the autologin PAM service to support keyring setup without a password.
services/ddm.pam
services/debian.ddm.pam
services/ddm-autologin.pam
Recommend installation of the keyring helper package without making it a hard dependency.
  • Add deepin-keyring-whitebox to the package recommendations.
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, Groveer, wineee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Groveer
Groveer merged commit d56ce36 into linuxdeepin:master Oct 15, 2026
8 checks passed
@wineee
wineee deleted the pam branch October 15, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants