test: add unit tests for SecurityUtils, WakeupUtils, EnableUtils modules - #758
Merged
deepin-bot[bot] merged 1 commit intoSep 16, 2026
Merged
Conversation
Reviewer's GuideAdds 47 GTest unit cases across SecurityUtils, WakeupUtils, and EnableUtils, using temporary filesystem fixtures and direct access to private helpers to validate normal, invalid, and boundary behaviors without changing production code. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="deepin-devicemanager-server/tests/src/SecurityUtils/ut_securityutils.cpp" line_range="193-196" />
<code_context>
+TEST_F(SecurityUtilsTest, isSafeSysfsPath_validDevicesPath_returnsTrue)
+{
+ // Arrange
+ QString path = "/devices/pci0000:00/0000:00:01.0";
+
+ // Act
+ bool result = isSafeSysfsPath(path);
+
+ // Assert
</code_context>
<issue_to_address>
**issue (testing):** The test uses the hard-coded `/sys/devices/pci0000:00/0000:00:01.0` path, but `isSafeSysfsPath` requires the canonical path to exist. On hosts without that exact PCI device, the function returns false and the test fails despite the input being intended as a valid case.
**Triggers:** When the test runs on a machine whose sysfs topology does not contain `/sys/devices/pci0000:00/0000:00:01.0`.
**Suggested fix:** Create or select an actually existing sysfs path at runtime, or mock the filesystem-dependent validation before asserting the positive result.
</issue_to_address>
Comment on lines
+193
to
+196
| QString path = "/devices/pci0000:00/0000:00:01.0"; | ||
|
|
||
| // Act | ||
| bool result = isSafeSysfsPath(path); |
There was a problem hiding this comment.
issue (testing): The test uses the hard-coded /sys/devices/pci0000:00/0000:00:01.0 path, but isSafeSysfsPath requires the canonical path to exist. On hosts without that exact PCI device, the function returns false and the test fails despite the input being intended as a valid case.
Triggers: When the test runs on a machine whose sysfs topology does not contain /sys/devices/pci0000:00/0000:00:01.0.
Suggested fix: Create or select an actually existing sysfs path at runtime, or mock the filesystem-dependent validation before asserting the positive result.
lzwind
approved these changes
Sep 16, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…bleUtils modules - Add ut_securityutils.cpp with 18 test cases covering SecurityUtils functions - Add ut_wakeuputils.cpp with 14 test cases covering WakeupUtils functions - Add ut_enableutils.cpp with 15 test cases covering EnableUtils functions 测试(单测): 新增 SecurityUtils、WakeupUtils 和 EnableUtils 模块单元测试 - 新增 ut_securityutils.cpp，包含 18 个测试用例，覆盖 SecurityUtils 各功能函数 - 新增 ut_wakeuputils.cpp，包含 14 个测试用例，覆盖 WakeupUtils 各功能函数 - 新增 ut_enableutils.cpp，包含 15 个测试用例，覆盖 EnableUtils 各功能函数 Log: 为 deepin-devicemanager 的 SecurityUtils、WakeupUtils、EnableUtils 三个工具模块补充单元测试，共新增 47 个测试用例
add-uos
force-pushed
the
agent/9559afe28640-ut
branch
from
September 16, 2026 06:04
d64079e to
e8fd8d9
Compare
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
📋 漏洞对比统计
🔍 详细分析1. 语法逻辑 ✅ (25/25 分)评价： 语法正确，逻辑清晰 ✅ 通过 分析：
潜在问题： 2. 代码质量 ✅ (24/25 分)评价： 代码结构清晰，注释完整 ✅ 通过 分析：
潜在问题：
改进建议： // 可提取为辅助函数，减少重复代码
static QStringList createTestLines(const QString &hardwareClass)
{
QStringList lines;
for (int i = 0; i < 12; ++i)
lines << QString("Key%1: Value%1").arg(i);
lines[0] = "Hardware Class: " + hardwareClass;
return lines;
}3. 代码性能 ✅ (20/20 分)评价： 性能良好，资源使用合理 ✅ 通过 分析：
潜在问题： 4. 代码安全 🔒 (30/30 分)评价： 存在0个安全漏洞 ✅ 通过
分析：
安全漏洞详情： 漏洞对比统计：新增漏洞 0 个，减少漏洞 0 个，持平 0 个 📝 审查总结本次 PR 为
优点：
改进建议：
本报告由 AI 代码审查工具自动生成 |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
为 deepin-devicemanager 项目补充 3 个模块的 GTest 单元测试，共 47 个用例，全部编译通过且测试全绿。
Test Coverage
Test Results
Commits
94907f9atest: add unit tests for securityutils module56b9ea78test: add unit tests for wakeuputils moduled64079e3test: add unit tests for enableutils moduleSummary by Sourcery
Tests: