Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR adds V6.6 AT-SPI test specifications and executable suites for find-result counting and Markdown workflows, marks unsupported or flaky cases with explicit reasons, and adds the accessible names and element metadata required to discover the tested controls. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tests/at/v6.6/cases_mapped.yaml" line_range="342" />
<code_context>
+ reason: 性能/资源-大文件查找耗时
+
+ # ============================================================
+ # 模块二：Markdown 文档渲染（24 例，12 active + 12 unsupported）
+ # ============================================================
+
+ - id: v6.6-md-001
+ name: 新建文件_纯文本不渲染
</code_context>
<issue_to_address>
**nitpick:** The generated file comments state that the Markdown module has 24 cases with 12 active and 12 unsupported, but the file contains 24 Markdown IDs with 15 active and 9 unsupported; the overall comments also describe counts inconsistent with the actual contents. Reports or tooling that rely on these stated counts are incorrect.
**Suggested fix:** Regenerate or correct the case-count comments to match the actual case statuses.
```suggestion
# 模块二：Markdown 文档渲染（24 例，15 active + 9 unsupported）
```
</issue_to_address>
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 代码语法正确，逻辑清晰。4个C++文件均正确调用 setAccessibleName()，该方法是 QWidget 的标准接口，QLabel、DMenu、QWebEngineView、DDropdownMenu 均继承自 QWidget，方法可用。对象在调用前已完成创建，无空指针风险。YAML 测试文件语法正确，结构完整。 2. 代码质量 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 代码结构清晰，注释完整。新增的 setAccessibleName() 调用位置合理，紧接对象创建语句之后。YAML 测试文件包含完整的 metadata、annotation、steps 和 assert 定义，文档化程度高。无重复代码，无残留调试信息。 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 性能良好，资源使用合理。setAccessibleName() 是 Qt 的轻量级属性设置方法，仅设置内部字符串属性，无性能影响。无频繁系统调用，无资源泄漏。 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： 无安全风险，代码安全合规。本次变更不涉及用户输入处理、网络通信、文件操作或敏感数据处理。accessible name 均为静态字符串字面量，无注入风险。markdownview.cpp 中已有的 URL scheme 白名单安全机制（仅放行 http/https）未受本次变更影响。 💡 改进建议代码示例// 本次变更无需修复代码示例
// 所有变更均为标准的 setAccessibleName() 调用，语法正确，实现合理
// 示例变更（src/controls/linebar.cpp 第36行）：
// m_matchCountLabel->setAccessibleName("MatchCountLabel");
// 该调用为 Qt 无障碍API标准用法，无需修改本报告由 AI 代码审查工具自动生成 |
JWWTSL
force-pushed
the
master
branch
2 times, most recently
from
September 11, 2026 03:31
39db968 to
c9d92a5
Compare
Add missing setAccessibleName for AT-SPI test element location: - MatchCountLabel in linebar.cpp (find result count label) - MarkdownView in markdownview.cpp (markdown render view) - ViewModeContextMenu in dtextedit.cpp (right-click view mode submenu) - HighlightMenu in bottombar.cpp (syntax highlight dropdown) The V6.6 AT test suites (22 cases: find count 7 + markdown render 15) are maintained in the app-test-v25 repository (tests/at/yaml/查找计数, tests/at/yaml/Markdown渲染) and verified 22/22 PASS via youqu at run.
Contributor
|
TAG Bot New tag: 6.6.3 |
Contributor
|
TAG Bot New tag: 6.6.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… rendering
Add 32 test cases (22 active, 10 unsupported) covering two V6.6 features:
Also add missing accessible names for AT-SPI element discovery:
Update expected_names.yaml with 7 new element entries.
Flaky cases (md-009/md-010 consecutive right-click timing) removed from suite and marked manual with reason in standard/mapped yaml.
Verification: youqu at run 22/22 specs PASS (find-count 7/7, markdown-render 15/15)
Summary by Sourcery
Expand V6.6 accessibility test coverage for find results and Markdown rendering while improving UI element discoverability.
Enhancements:
Tests:
Chores: