fix(search): preserve whitespace for English locale search filtering - #650
Merged
deepin-bot[bot] merged 1 commit intoSep 4, 2026
Conversation
Previously all whitespace was removed from search text regardless of locale, breaking multi-word searches in English. Extract the filtering logic into a shared helper and only strip whitespace for non-English locales. Log: 修复英文环境下搜索多词内容时空格被过滤导致搜索失败的问题 PMS: BUG-373531 Influence: 英文环境下多词搜索结果正常返回,非英文环境行为不变
GongHeng2017
force-pushed
the
202609041102-re-eagle-fix
branch
from
September 4, 2026 05:54
2f4ddf9 to
d64bf3d
Compare
lzwind
approved these changes
Sep 4, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GongHeng2017, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Reviewer's GuideSearch text filtering is now shared across all search entry points and preserves whitespace for English locales, allowing multi-word searches while retaining the previous whitespace-stripping behavior elsewhere. Sequence diagram for locale-aware search filteringsequenceDiagram
participant User
participant WebWindow
participant SearchManager
User->>WebWindow: onSearchContentByKeyword(keyword)
WebWindow->>WebWindow: filterSearchText(keyword)
alt English locale
WebWindow->>SearchManager: searchContent(searchKey with spaces)
else Non-English locale
WebWindow->>SearchManager: searchContent(searchKey without whitespace)
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
This pr force merged! (status: unstable) |
deepin-bot
Bot
merged commit Sep 4, 2026
8ab4aff
into
linuxdeepin:release/eagle
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all whitespace was removed from search text regardless of locale, breaking multi-word searches in English. Extract the filtering logic into a shared helper and only strip whitespace for non-English locales.
Log: 修复英文环境下搜索多词内容时空格被过滤导致搜索失败的问题
PMS: BUG-373531
Influence: 英文环境下多词搜索结果正常返回,非英文环境行为不变
Summary by Sourcery
Preserve whitespace in English search input while maintaining locale-specific filtering for other languages.
Bug Fixes:
Enhancements: