Skip to content

fix: QtPlayer volume setting - convert int to qreal #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Aug 26, 2026
+2 −2
Merged

fix: QtPlayer volume setting - convert int to qreal #745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libdmusic/player/qtplayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ void QtPlayer::setFadeInOutFactor(double fadeInOutFactor)
{
qCDebug(dmMusic) << "Set fade in/out factor";
init();
m_audioOutput->setVolume(static_cast<int>(10 * fadeInOutFactor));
m_audioOutput->setVolume(qBound(0.0, static_cast<qreal>(m_volume) / 100.0 * fadeInOutFactor, 1.0));
}

void QtPlayer::setVolume(int volume)
Expand All @@ -209,7 +209,7 @@ void QtPlayer::setVolume(int volume)
init();
qCDebug(dmMusic) << "Setting volume to:" << volume;
m_volume = volume;
m_audioOutput->setVolume(volume);
m_audioOutput->setVolume(volume / 100.0);
}

int QtPlayer::getVolume()
Expand Down
Loading