fix: improve search result UI and navigation - #748
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kt286 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kt286. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideRefactors the search results page to use a StackView-based navigation with animated push/pop transitions, updates artist/album grid layouts, improves the search suggestion dialog interaction and styling, and adjusts sidebar behavior and navigation signal wiring for artist/album detail views. Sequence diagram for StackView-based search result navigationsequenceDiagram
actor User
participant ArtistGridDelegate
participant SearchResultWindow
participant globalVariant
participant navigationStackView
participant ArtistSublistView
User->>ArtistGridDelegate: onItemDoubleClicked(artistData)
ArtistGridDelegate->>SearchResultWindow: itemDoubleClicked(artistData)
activate SearchResultWindow
SearchResultWindow->>SearchResultWindow: onItemDoubleClicked(data)
SearchResultWindow->>SearchResultWindow: artistData = data
SearchResultWindow->>SearchResultWindow: selectedArtistName = data.name
SearchResultWindow->>globalVariant: globalSwitchButtonStatus = 2
deactivate SearchResultWindow
globalVariant-->>SearchResultWindow: onSwitchTypeChanged(switchType = 2)
activate SearchResultWindow
SearchResultWindow->>navigationStackView: push(artistSublistView)
navigationStackView-->>ArtistSublistView: create and show
deactivate SearchResultWindow
globalVariant-->>SearchResultWindow: onReturnUpperlevelView()
activate SearchResultWindow
SearchResultWindow->>SearchResultWindow: returnUpperlevelView()
SearchResultWindow->>globalVariant: globalSwitchButtonStatus = 0
SearchResultWindow->>navigationStackView: pop(initialItem)
deactivate SearchResultWindow
Sequence diagram for SearchResultDialog item selection and closesequenceDiagram
actor User
participant SearchResultDialog
participant ItemDelegate
User->>ItemDelegate: MouseArea.onClicked
ItemDelegate->>SearchResultDialog: searchItemTriggered(value, type)
ItemDelegate->>SearchResultDialog: requestClose()
SearchResultDialog-->>SearchResultDialog: Popup close handled externally
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
8f30dba to
ad17847
Compare
|
TAG Bot New tag: 7.0.63 |
|
TAG Bot New tag: 7.0.64 |
ad17847 to
caeed40
Compare
|
TAG Bot New tag: 7.0.65 |
|
TAG Bot New tag: 7.0.66 |
- Overhaul SearchResultWindow navigation with StackView for push/pop transitions - Adjust grid cell sizes for better artist and album display - Add requestClose signal and padding/radius improvements to SearchResultDialog - Remove sidebar auto-uncheck behavior when entering search page - Fix connection handlers for artist and album detail navigation fix: 优化搜索结果UI和导航 - 使用StackView重构SearchResultWindow导航,支持推入/弹出过渡动画 - 调整网格单元格大小以改善歌手和专辑显示 - 为SearchResultDialog添加requestClose信号和内边距/圆角改进 - 移除进入搜索页面时侧边栏自动取消勾选的行为 - 修复歌手和专辑详情页导航的连接处理
caeed40 to
2ba587a
Compare
fix: 优化搜索结果UI和导航
主要解决几个问题
1、搜索结果中的专辑、艺人点击三个点,查看详情无法跳转到详情界面
2、点击搜索结果中的艺人、专辑后,再点主界面左侧的艺人、专辑,有可能会没有蓝色高亮
3、参考艺人,专辑列表,给搜索结果适配动画和上一页下一页
Summary by Sourcery
Improve search results navigation and UI responsiveness across the search window, dialog, and sidebar.
New Features:
Bug Fixes:
Enhancements:
Summary by Sourcery
Improve search result navigation and presentation with animated detail transitions and more reliable selection behavior.
New Features:
Bug Fixes:
Enhancements: