fix: remove SystemPalette and use hardcoded colors in sidebar - #764
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kt286 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @kt286. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes usage of SystemPalette from sidebar QML components and replaces it with hardcoded, theme-aware colors for foreground text and placeholder text, to ensure correct color behavior when switching dark mode on Windows. Flow diagram for sidebar text color selection logicflowchart TD
A[SidebarItemDelegate.checked] -->|true| B{DTK.themeType}
A -->|false| C{DTK.themeType}
B -->|ApplicationHelper.DarkType| D[foregroundColor = #FFFFFF]
B -->|else| E[foregroundColor = #FFFFFF]
C -->|ApplicationHelper.DarkType| F[foregroundColor = #B2F7F7F7]
C -->|else| G[foregroundColor = #000000]
H[SidebarItem.title placeholder] --> I{DTK.themeType}
I -->|ApplicationHelper.DarkType| J[color = Qt.rgba 247 247 247 0.7]
I -->|else| K[color = Qt.rgba 0 0 0 0.7]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
db9f15c to
30b2519
Compare
|
TAG Bot New tag: 7.0.64 |
30b2519 to
6090344
Compare
|
TAG Bot New tag: 7.0.65 |
|
TAG Bot New tag: 7.0.66 |
fix: 移除 SystemPalette,侧边栏使用硬编码颜色
6090344 to
6e434f7
Compare
fix: 移除 SystemPalette,侧边栏使用硬编码颜色
使用系统调色板后,Windows 下切换深色模式时颜色不会变化
Summary by Sourcery
Use explicit theme-aware colors in sidebar components to keep their appearance stable across system theme changes.
Bug Fixes:
Enhancements:
Chores: