Skip to content

fix: always recalculate position to prevent issues on window resize - #782

Open
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/recalculate-on-resize
Open

fix: always recalculate position to prevent issues on window resize#782
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/recalculate-on-resize

Conversation

@kt286

@kt286 kt286 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Remove the conditional check that only calculated the position when defaultY was negative. Now the position is recalculated every time on hover, preventing layout issues when the window size changes.

fix: 每次都重新计算,防止窗口大小变化时有问题

移除仅在 defaultY 为负值时才计算位置的条件判断。
现在悬停时每次都重新计算位置,防止窗口大小变化时出现布局问题。

Summary by Sourcery

Recalculate grid item positions on every hover to prevent layout issues when the window size changes.

Bug Fixes:

  • Recalculate album and artist grid positions on every hover to keep hover layouts correct after window resizing.

Chores:

  • Update SPDX copyright years in the affected QML files.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @kt286, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates album and artist hover delegates to refresh their mapped Y position on every hover, ensuring hover layouts remain correct after window resizing or other geometry changes.

Sequence diagram for recalculating hover position

sequenceDiagram
    participant User
    participant AlbumGridDelegate
    participant ArtistGridDelegate
    participant Column
    participant Parent
    participant HoverAnimator

    User->>AlbumGridDelegate: onHoveredChanged
    AlbumGridDelegate->>Column: mapToItem(Parent, x, y)
    Column-->>AlbumGridDelegate: p.y
    AlbumGridDelegate->>AlbumGridDelegate: defaultY = p.y
    AlbumGridDelegate->>HoverAnimator: start()

    User->>ArtistGridDelegate: onHoveredChanged
    ArtistGridDelegate->>Column: mapToItem(Parent, x, y)
    Column-->>ArtistGridDelegate: p.y
    ArtistGridDelegate->>ArtistGridDelegate: defaultY = p.y
    ArtistGridDelegate->>HoverAnimator: start()
Loading

File-Level Changes

Change Details Files
Recalculate the hover overlay’s Y position on every hover activation instead of caching the initial value.
  • Always map the album column coordinates into the parent coordinate system before starting the hover animation.
  • Always map the artist column coordinates into the parent coordinate system before starting the hover animation.
src/music-player/albumlist/AlbumGridDelegate.qml
src/music-player/singerlist/ArtistGridDelegate.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

Hi @kt286. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Remove the conditional check that only calculated the position when
defaultY was negative. Now the position is recalculated every time
on hover, preventing layout issues when the window size changes.

fix: 每次都重新计算,防止窗口大小变化时有问题

移除仅在 defaultY 为负值时才计算位置的条件判断。
现在悬停时每次都重新计算位置,防止窗口大小变化时出现布局问题。
@kt286
kt286 force-pushed the fix/recalculate-on-resize branch from 6c0a43e to d4a71aa Compare August 24, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants