refactor(modules): drop redundant wl_resource type checks

[deepin-wm]

Summary

libwayland already validates object arguments before a request handler runs:

• wl_connection_demarshal() rejects id 0 for non-nullable object arguments.
• wl_closure_lookup_objects() rejects unknown object ids and type mismatches with WL_DISPLAY_ERROR_INVALID_METHOD; the handler is never invoked on error. Server-side destroyed resources are removed from the client object map, so their ids fail lookup as well.

Hence in the touched request handlers the object arguments are always non-NULL and of the protocol-declared type; the self-made strcmp(wl_resource_get_class(...)) checks were unreachable dead code. Remove them and the now-unused <cstring>/<string.h> includes.

Real checks are kept: cross-client ownership (decoration), inert seat (wlr_seat_client_from_resource), removed output (WOutput::fromHandle NULL), missing WSurface wrapper, and the protocol size/anchor enum validations. The capture module / waylib Q_ASSERT(wl_resource_instance_of(...)) debug asserts (mirroring wlroots' own wlr_*_from_resource style) are intentionally left untouched.

变更说明

删除四个模块请求处理函数中自行做的 wl_resource 类型检查：libwayland 分发层已在校验对象参数的类型与有效性（wl_closure_lookup_objects 对未知 id / 类型不匹配报 WL_DISPLAY_ERROR_INVALID_METHOD，不可空参数不会为 NULL，已销毁 resource 的 id 在服务端对象表中查不到），这些检查不可达。保留跨 client 归属检查、inert resource 判空与协议错误校验。

Files changed (+2/−42)

• src/modules/decoration/decorationmanagerinterfacev1.cpp
• src/modules/active-notify/activenotifymanagerinterfacev1.cpp
• src/modules/region-watch/regionwatchmanagerinterfacev1.cpp
• src/modules/xwindow-control/xwindowcontrolinterfacev1.cpp

Verification

Full build passes on the build machine: cmake --preset=default && cmake --build build -j50 (1915/1915 targets).

Summary by Sourcery

Rely on libwayland’s request dispatch validation instead of duplicating unreachable resource checks in module handlers.

Enhancements:

• Remove redundant Wayland resource type and null checks from four module request handlers, relying on libwayland’s dispatch validation while retaining meaningful ownership, lifecycle, wrapper, and protocol validation.

Chores:

• Remove unused C string headers from the affected modules.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The handlers now rely on libwayland to reject null, unknown, destroyed, or incorrectly typed object arguments before invocation, eliminating duplicated resource checks while retaining checks for client ownership, resource state, wrapper availability, and protocol-specific validation.

Sequence diagram for libwayland request object validation

sequenceDiagram
    participant Client
    participant Wayland as libwayland
    participant Handler as RequestHandler
    participant Resource as ResourceAPI

    Client->>Wayland: request with object id
    Wayland->>Wayland: wl_connection_demarshal()
    alt invalid object id or type
        Wayland-->>Client: WL_DISPLAY_ERROR_INVALID_METHOD
    else valid protocol object
        Wayland->>Handler: invoke request handler
        Handler->>Resource: perform ownership/state/wrapper checks
        Resource-->>Handler: validation result
    end

Loading

Flow diagram for simplified object request handling

flowchart TD
    A[Wayland request received] --> B{libwayland object validation}
    B -->|invalid, null, unknown, destroyed, or wrong type| C[Reject before handler]
    B -->|valid protocol-declared object| D[Invoke module handler]
    D --> E{Meaningful module checks}
    E -->|ownership, resource state, wrapper, or protocol validation fails| F[Post protocol error]
    E -->|valid| G[Perform requested operation]

Loading

File-Level Changes

Change	Details	Files
Remove redundant Wayland resource class and null checks from request handlers, relying on libwayland dispatch validation.	Delete unreachable checks for seat, surface, output, and anchor resource types. Remove now-unused C string comparison headers. Preserve meaningful ownership, inert-resource, wrapper, and protocol validation paths.	src/modules/active-notify/activenotifymanagerinterfacev1.cpp src/modules/decoration/decorationmanagerinterfacev1.cpp src/modules/region-watch/regionwatchmanagerinterfacev1.cpp src/modules/xwindow-control/xwindowcontrolinterfacev1.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[deepin-wm]

recheck

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-wm, wineee

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment