Repository navigation
Revert "fix(xwayland): sync cursor global position to X server" - #1458
Merged
Merged
Conversation
This reverts commit 5fe9fd7.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts the previous Xwayland cursor synchronization implementation by removing cursor tracking and XCB pointer warping, preventing global cursor updates from being delivered to X clients as genuine mouse events while retaining normal seat setup. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="waylib/src/server/protocols/wxwayland.cpp" line_range="430" />
<code_context>
-
- d->watchSeatCursor();
- d->syncCursorPositionToXWayland();
+ wlr_xwayland_set_seat(handle, seat->handle());
}
</code_context>
<issue_to_address>
**Clearing the seat crashes compositor**
When a caller invokes `setSeat(nullptr)` while the Xwayland handle exists, `WXWayland::setSeat` evaluates `seat->handle()` unconditionally, dereferencing null before `wlr_xwayland_set_seat` can detach the seat and terminating the compositor.
Pass `nullptr` to `wlr_xwayland_set_seat` when `seat` is null; otherwise pass `seat->handle()`.
</issue_to_address>
zzxyb
self-requested a review
October 8, 2026 02:23
zzxyb
approved these changes
Oct 8, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zccrs, zzxyb The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
ArchLinux 的构建问题是Qt6.12的适配,本次暂不处理。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1430
It should not be implemented in this way, as this will cause Xwayland to send these events to X clients as genuine mouse
operations, which is not what we intend; we only wish for X to update the cursor coordinates.
Summary by Sourcery
Revert Xwayland cursor position synchronization to avoid generating unintended mouse events for X clients.
Bug Fixes:
Enhancements: